This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: e633410 | Previous: b234c1c | Ratio |
|---|---|---|---|
processingTx |
8495 ops/sec (±4.80%) |
9042 ops/sec (±4.12%) |
1.06 |
processingContractDeploy |
35433 ops/sec (±7.99%) |
38054 ops/sec (±6.81%) |
1.07 |
processingContractMethodSend |
17411 ops/sec (±7.96%) |
18746 ops/sec (±7.29%) |
1.08 |
processingContractMethodCall |
35559 ops/sec (±3.96%) |
39055 ops/sec (±5.29%) |
1.10 |
abiEncode |
38649 ops/sec (±9.54%) |
43251 ops/sec (±6.96%) |
1.12 |
abiDecode |
28509 ops/sec (±6.46%) |
29622 ops/sec (±6.71%) |
1.04 |
sign |
1554 ops/sec (±3.64%) |
1542 ops/sec (±4.29%) |
0.99 |
verify |
363 ops/sec (±0.64%) |
363 ops/sec (±1.04%) |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7088 +/- ##
=======================================
Coverage 93.98% 93.99%
=======================================
Files 215 215
Lines 8335 8344 +9
Branches 2301 2302 +1
=======================================
+ Hits 7834 7843 +9
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
approved these changes
Jun 10, 2024
luu-alex
approved these changes
Jun 10, 2024
Merged
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#7002
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.