fix: resolve @import with absolute paths#201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 7 7
Lines 97 97
Branches 8 9 +1
=======================================
Hits 95 95
Misses 2 2
Continue to review full report at Codecov.
|
@import with absolute paths
|
Fixes #93 |
|
@n1ru4l Please add a test for this |
bebraw
left a comment
There was a problem hiding this comment.
This needs a test.
I wonder if it would be better to fix loaderUtils.urlToRequest call (possible?). That would push complexity elsewhere, though. See https://github.com/webpack/loader-utils/blob/master/lib/urlToRequest.js .
|
@n1ru4l Yeah, I think it would take some refactoring (extracting class?) to test this. But it's worth doing to avoid breaking the feature in the future. |
|
@bebraw I will try that! |
|
@bebraw I added a test that does not require any refactoring |
No description provided.