Conversation
joshwiens
changed the title
joshwiens
changed the title
- Updates code style to Prettier - Updates engines - Updates peerDependencies - Enforces commit message formatting - Migrates to CircleCI 2.0 - Removes deprecated React JSX support BREAKING CHANGE: Drops support for NodeJS 4.x BREAKING CHANGE: Drops support for Webpack 2.x
BREAKING CHANGE: Less Loader now enforces it's options & types, incorrect configurations with throw.
joshwiens
requested review from
alexander-akait,
jhnns and
michael-ciniawsky
michael-ciniawsky
suggested changes
Dec 21, 2017
Contributor
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
Needs a test for ValidationError (schema-utils)
The test and README also needs standardization, but that are separate PR's I guess
| @@ -0,0 +1,6 @@ | |||
| # These are the default owners for everything in | |||
| # webpack-contrib | |||
| @webpack-contrib/org-maintainers | |||
Contributor
There was a problem hiding this comment.
@jhnnns @webpack-contrib/org-maintainers
If he still actively wants to be pinged for review 😛
| function lessLoader(source) { | ||
| const loaderContext = this; | ||
| const options = getOptions(loaderContext); | ||
| validateOptions(schema, options, 'lessLoader'); |
Contributor
There was a problem hiding this comment.
\nvalidateOptions(...)\n && lessLoader => Less Loader
| * @returns {LessError} | ||
| */ | ||
| function formatLessError(err) { /* eslint-disable no-param-reassign */ | ||
| function formatLessError(err) { |
Contributor
There was a problem hiding this comment.
class LessError extends Error {
super();
this.name = 'Syntax Error';
this.message = `${err.message}\n\n`;
// ...message formating
Error.captureStackTrace(this, this.constructor)
}
export default LessError;
Contributor
There was a problem hiding this comment.
This maybe a separate PR aswell
Closed
michael-ciniawsky
changed the title
This was referenced Feb 27, 2018
Member
|
@d3viant0ne I guess this has been superseded by #253? Anyway, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility issues
Commit message body
@jhnns - A note on the changes to the testing infrastructure. Non windows validation is now handled via CircleCI 2.0 on custom build containers.
The validation runs analysis & validations on the lowers common denominator ( maint LTS node + webpack latest ). If those to jobs pass, if will run the remaining validations in a
fan-outconfiguration.End result is a 50% reduction in build feedback, complete control over our build / test environment & validation on
webpack@nextas well asnode@next.There is a release task in the build setup as well that can be enabled at the request of the lib owner ( in this case you ).