fix: Remove unused v dependency#517
Merged
alexander-akait merged 1 commit intowebpack:masterfrom May 31, 2023
askoufis:remove-v-dep
Merged
fix: Remove unused v dependency#517alexander-akait merged 1 commit intowebpack:masterfrom askoufis:remove-v-dep
v dependency#517alexander-akait merged 1 commit intowebpack:masterfrom
askoufis:remove-v-dep
Conversation
|
I came to the same conclusion and I agree, |
alexander-akait
approved these changes
May 31, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 3 3
Lines 151 151
Branches 33 33
=======================================
Hits 141 141
Misses 10 10 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Seems like a dependency on the
vpackage was added during this chore PR. This seems like an accident to me as thevpackage doesn't seem related at all toless-loader.