Skip to content

Fix data-uri (issue #38)#58

Merged
sokra merged 1 commit intowebpack:masterfrom
next0:master
Nov 23, 2015
Merged

Fix data-uri (issue #38)#58
sokra merged 1 commit intowebpack:masterfrom
next0:master

Conversation

@next0
Copy link
Copy Markdown
Contributor

@next0 next0 commented Sep 28, 2015

Fix issue #38 :

Module build failed: error evaluating function `data-uri`: Cannot 'resolveSync' because the fileSystem is not sync. Use 'resolve'!

@next0
Fix issue webpack#38
6bb1d96 
```
Module build failed: error evaluating function `data-uri`: Cannot 'resolveSync' because the fileSystem is not sync. Use 'resolve'!
```
@ericmatthys
Copy link
Copy Markdown

ericmatthys commented Oct 2, 2015

This fixes the data-uri issue in my project. 👍

@next0 next0 mentioned this pull request Oct 20, 2015
Closed
@revolunet
Copy link
Copy Markdown

revolunet commented Oct 29, 2015

yes please :)

@XiXora
Copy link
Copy Markdown

XiXora commented Nov 4, 2015

+1

2 similar comments
@jeantroiani
Copy link
Copy Markdown

jeantroiani commented Nov 16, 2015

+1

@andresgarza
Copy link
Copy Markdown

andresgarza commented Nov 17, 2015

+1

@ftdebugger
Copy link
Copy Markdown

ftdebugger commented Nov 18, 2015

Merge please

@criyology
Copy link
Copy Markdown

criyology commented Nov 18, 2015

+1

10 similar comments
@vlyahovich
Copy link
Copy Markdown

vlyahovich commented Nov 18, 2015

+1

@antejan
Copy link
Copy Markdown

antejan commented Nov 18, 2015

+1

@roman-mazhut
Copy link
Copy Markdown

roman-mazhut commented Nov 18, 2015

+1

@NeXidan
Copy link
Copy Markdown

NeXidan commented Nov 18, 2015

👍

@DenisHomich
Copy link
Copy Markdown

DenisHomich commented Nov 18, 2015

+1

@dontuncleme
Copy link
Copy Markdown

dontuncleme commented Nov 18, 2015

+1

@Tocher
Copy link
Copy Markdown

Tocher commented Nov 18, 2015

👍

@lifus
Copy link
Copy Markdown

lifus commented Nov 18, 2015

+1

@nchereva
Copy link
Copy Markdown

nchereva commented Nov 19, 2015

👍

@dorsha
Copy link
Copy Markdown

dorsha commented Nov 19, 2015

+1

sokra added a commit that referenced this pull request Nov 23, 2015
@sokra
Merge pull request #58 from next0/master
fdda45b 
Fix data-uri (issue #38)
@sokra sokra merged commit fdda45b into webpack:master Nov 23, 2015
@sokra
Copy link
Copy Markdown
Member

sokra commented Nov 23, 2015

Thanks

@revolunet
Copy link
Copy Markdown

revolunet commented Nov 23, 2015

thanks

@jhnns
Copy link
Copy Markdown
Member

jhnns commented Nov 25, 2015

@next0 Awesome! You've even included tests 👍

@jhnns
Copy link
Copy Markdown
Member

jhnns commented Nov 25, 2015

Fix shipped with 2.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
⚡