fix(a11y): fixed background contrast issue in Lighthouse #8185
Open
pranjalisr wants to merge 2 commits intowebpack:mainfrom
Open
fix(a11y): fixed background contrast issue in Lighthouse #8185pranjalisr wants to merge 2 commits intowebpack:mainfrom
pranjalisr wants to merge 2 commits intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@evenstensberg Please review. |
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Can you provide before and after to see different, sometimes it is hard to understand fast when we change something in design, thanks
Contributor
Author
|
Fixed Background and foreground colors do not have sufficient contrast ratio under Contrast issue in Lighthouse audit Before |
Member
|
light gray is looking not good in design, we need to search other color, also please do not hardcode colors we have theme please use/add colors to this file |
Contributor
Author
|
Please review. Accessibility score is now 96 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Background and foreground colors do not have sufficient contrast ratio under Contrast issue in Lighthouse.
What kind of change does this PR introduce?
Code change
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
Copilot