Fix package-entry hint for bare specifier in main (resolve #1693)

Author: webpro

packages/knip/fixtures/package-entry-bare/index.ts

@@ -0,0 +1 @@
+export const placeholder = true;

packages/knip/fixtures/package-entry-bare/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "@fixture/package-entry-bare",
+  "main": "bare-dep/entry",
+  "dependencies": {
+    "bare-dep": "*"
+  }
+}

packages/knip/src/graph/build.ts

@@ -175,13 +175,16 @@ export async function build({
     }
 
     for (const identifier of entrySpecifiersFromManifest) {
-      if (!identifier.startsWith('!') && !isGitIgnored(join(dir, identifier))) {
-        const exists = identifier.includes('*')
-          ? _syncGlob({ patterns: [identifier], cwd: dir }).length > 0
-          : existsSync(join(dir, identifier));
-        if (!exists) {
-          collector.addConfigurationHint({ type: 'package-entry', filePath, identifier, workspaceName: name });
-        }
+      if (identifier.startsWith('!') || isGitIgnored(join(dir, identifier))) continue;
+      if (!identifier.startsWith('.') && !identifier.startsWith('/')) {
+        const packageName = getPackageNameFromModuleSpecifier(identifier);
+        if (packageName && dependencies.has(packageName)) continue;
+      }
+      const exists = identifier.includes('*')
+        ? _syncGlob({ patterns: [identifier], cwd: dir }).length > 0
+        : existsSync(join(dir, identifier));
+      if (!exists) {
+        collector.addConfigurationHint({ type: 'package-entry', filePath, identifier, workspaceName: name });
       }
     }
 

packages/knip/test/package-entry-bare.test.ts

@@ -0,0 +1,14 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../src/index.ts';
+import { createOptions } from './helpers/create-options.ts';
+import { resolve } from './helpers/resolve.ts';
+
+const cwd = resolve('fixtures/package-entry-bare');
+
+test('No package-entry hint for bare specifier in main when first segment is a listed dependency', async () => {
+  const options = await createOptions({ cwd });
+  const { configurationHints } = await main(options);
+
+  assert.deepEqual(configurationHints, []);
+});