Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #420 +/- ##
==========================================
+ Coverage 50.75% 50.85% +0.09%
==========================================
Files 83 86 +3
Lines 15821 16024 +203
==========================================
+ Hits 8030 8149 +119
- Misses 7185 7257 +72
- Partials 606 618 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cocowh
force-pushed
the
cluster_group
branch
2 times, most recently
from
91f7064 to
4b2f8dc
Compare
cluster/clusterGroup.go
Outdated
| clusterGroup.clusterSelector = clusterSelector | ||
|
|
||
| // backupSwitcher | ||
| clusterGroup.backupSwitcher = motan.GetSwitcherManager().GetOrRegister("feature.motan.backup.cluster.enable", true) |
core/globalContext.go
Outdated
| // first check file config and framework set value | ||
| groups := serviceURL.GetParam(SandboxGroupsKey, GetDefaultSandboxGroups()) | ||
| // second check env config | ||
| if groups == "" && len(changeGroupsConfig) > 0 { |
core/globalContext.go
Outdated
| return envMap | ||
| } | ||
|
|
||
| func (c *Context) parseServiceGroups(serviceURL *URL, serverMode string, changeGroupsConfig map[*regexp.Regexp]string) string { |
cocowh
force-pushed
the
cluster_group
branch
3 times, most recently
from
205ec44 to
21ab029
Compare
cocowh
force-pushed
the
cluster_group
branch
2 times, most recently
from
747c396 to
3153ee8
Compare
cluster group cluster group cluster group cluster group code review code review bugfix bugfix bugfix unit test bugfix bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.