Open
Conversation
Collaborator
|
I think it's better if we add the experiment results on AIShell-1 and LibriSpeech, to show that we can get consistent and solid gain by using the model. |
kobenaxie
reviewed
Oct 19, 2022
|
|
||
| def forward(self, x: torch.Tensor) -> torch.Tensor: | ||
| b, c, _, _ = x.size() | ||
| y = self.avg_pool(x).view(b, c) |
Contributor
There was a problem hiding this comment.
avg_pool over T and D dim should consider pad_mask ?
There was a problem hiding this comment.
thanks for your remind, we will update pad_mask to the code and retrain it .
Author
@robin1001 results of aishell has been added |
|
hi, i run blockformer in 3080 and it just used 30% - 40% gpu. I change batchsize bigger and numworker but it didn't work. So what should i do to take more use of gpu? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about implementation of blockformer in WeNet.
(Original paper: https://arxiv.org/abs/2207.11697)
In main branch, extracting features by torchaudio make a little worse results than the paper. I will push a branch using kaldi features for aishell recipe which can reproduce results in the paper.