Skip to content

iOS runtime#1549

Merged
robin1001 merged 13 commits intowenet-e2e:mainfrom
Ma-Dan:ios
Nov 14, 2022
Merged

iOS runtime#1549
robin1001 merged 13 commits intowenet-e2e:mainfrom
Ma-Dan:ios

Conversation

@Ma-Dan
Copy link
Copy Markdown
Contributor

@Ma-Dan Ma-Dan commented Nov 9, 2022

Sorry for the delayed PR, please review this version.

Comment thread runtime/core/decoder/ios_asr_model.cc Outdated
Comment thread runtime/core/decoder/ios_asr_model.cc Outdated
Comment thread runtime/core/decoder/ios_asr_model.cc Outdated
Comment thread runtime/core/decoder/ios_asr_model.cc Outdated
Comment thread runtime/core/decoder/ios_asr_model.cc Outdated
Comment thread runtime/ios/WenetDemo/WenetDemo/wenet/wenet.h
Comment thread runtime/ios/WenetDemo/WenetDemo/wenet/wenet.mm Outdated
Comment thread runtime/ios/api Outdated
Comment thread runtime/ios/bin Outdated
Comment thread runtime/ios/websocket Outdated
@pengzhendong
Copy link
Copy Markdown
Member

最后,还需要解决下述 lint 问题,并且写一个 README.md 描述用法。

@Ma-Dan
Copy link
Copy Markdown
Contributor Author

Ma-Dan commented Nov 10, 2022

目前还有如下几个问题:

  • 删除这些之后,需要处理的target少了很多,编译也节省了很多时间和空间,但是依然还剩下fst相关的6个execuatable target,关闭GRAPH_TOOLS后,这个手动处理已不再需要
  • swift 代码有相关 style 配置
  • lint

Comment thread runtime/ios/README.md Outdated
Comment thread runtime/ios/CMakeLists.txt Outdated
Comment thread runtime/core/decoder/ios_asr_model.cc Outdated
Copy link
Copy Markdown
Member

@pengzhendong pengzhendong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robin1001
Copy link
Copy Markdown
Collaborator

Great job! And I wonder if there is some video demo?

@robin1001 robin1001 merged commit d7fba09 into wenet-e2e:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants