Skip to content

Fix email auth freeze#5781

Open
tonisevener wants to merge 4 commits intoliquid-glassfrom
fix-email-auth-freeze
Open

Fix email auth freeze#5781
tonisevener wants to merge 4 commits intoliquid-glassfrom
fix-email-auth-freeze

Conversation

@tonisevener
Copy link
Copy Markdown
Collaborator

Phabricator: https://phabricator.wikimedia.org/T422086

Notes

We had another toast freeze when failing to enter the incorrect email auth code. I think this is a similar bug as #5746, mainly that our toasts freeze up when displayed or presented at the same time as the keyboard focus state. I am now adding a couple of modifiers to our toasts view.:

.focusable(false)
.focusEffectDisabled(true)

That does seem to fix this bug, so hopefully it will also fix it in other contexts we may not have found yet.

Test Steps

  1. Enable email auth code toggle in dev settings
  2. Log into account with email associated
  3. In email auth popup, enter an incorrect code.
  4. App should not freeze, you should see error message toast on top of keyboard.
  5. Ensure I didn't accidentally bring back create reading list bugs (https://phabricator.wikimedia.org/T421012).

Screenshots/Videos

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team April 3, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant