Skip to content

feat: add fill_hl config option#114

Merged
willothy merged 1 commit into
willothy:mainfrom
folliehiyuki:main
Jun 29, 2023
Merged

feat: add fill_hl config option#114
willothy merged 1 commit into
willothy:mainfrom
folliehiyuki:main

Conversation

@folliehiyuki

Copy link
Copy Markdown
Contributor

Make the colors of the filler space configurable.

From :h syntax.txt, I think we should use TabLineFill instead of TabLine. This might break people's tabline color, so I make the highlight group a config option and naively pass it to the render() function.

							*hl-TabLine*
TabLine		Tab pages line, not active tab page label.
							*hl-TabLineFill*
TabLineFill	Tab pages line, where there are no labels.

@willothy

willothy commented Jun 14, 2023

Copy link
Copy Markdown
Owner

This change makes sense to me overall, I don't think the config variable makes sense to pass to render() though. It's already in the global config table, we can just use the global from within render() instead. I'll look over this in more detail tonight though.

Make the colors of the filler space configurable.

@willothy willothy left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@willothy willothy merged commit 7ec240f into willothy:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants