🐛 fix: use correct path separators for unique_prefix depending on OS#2
Merged
Conversation
Collaborator
|
Thanks for the PR, I was aware of that bug but I had forgot all about it. To make it consisent with the style of the plugin could you rewrite that line as local path_separator = fn.has('win32') and '\\' or '/'then I'll merge into master.
It definitely should, I'll fix that right now. |
Collaborator
|
double quotes -> single quotes |
Contributor
Author
|
Done.!
Tysm! :D |
Collaborator
I've pushed a fix to master. |
Contributor
Author
|
Much appreciated! |
silvercircle
added a commit
to silvercircle/nvim-cokeline
that referenced
this pull request
Jul 2, 2023
silvercircle
added a commit
to silvercircle/nvim-cokeline
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unique_prefix was broken on windows, this fixes it.
Also, should unique_prefix only be returned when the number of buffers > 1?
Great plugin btw. :)