Skip to content

test: increase timeout for TC-2752 [WPB-22420]#21139

Merged
markbrockhoff merged 1 commit intodevfrom
mb/fix-app-lock-test-running-into-timeout
Apr 24, 2026
Merged

test: increase timeout for TC-2752 [WPB-22420]#21139
markbrockhoff merged 1 commit intodevfrom
mb/fix-app-lock-test-running-into-timeout

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Apr 24, 2026

TaskWPB-22420 [Web] General maintenance ticket for PR merges

Summary

The test waits 60s for the app lock modal to appear, this narrows the time left for the test itself to only 30s which is not enough in case the login takes a bit longer.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

The test waits 60s for the app lock modal to appear, this narrows the time left for the test itself to only 30s which is not enough in case the login takes a bit longer.
@sonarqubecloud
Copy link
Copy Markdown

@markbrockhoff markbrockhoff added this pull request to the merge queue Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 6
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 6
  • Total Runtime: 297.7s (~ 4 min 58 sec)

Merged via the queue into dev with commit 39f331c Apr 24, 2026
152 of 154 checks passed
@markbrockhoff markbrockhoff deleted the mb/fix-app-lock-test-running-into-timeout branch April 24, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants