refactor(build): don't emit middleware.mjs#12479
Merged
Merged
Conversation
|
florian-lefebvre
approved these changes
Nov 19, 2024
CodSpeed Performance ReportMerging #12479 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors our build by removing the necessity of having a file called
middleware.mjs. We were emittingmiddleware.mjsin order to have a predictable way to load the middleware file; however, since we started emitting the middleware chunk as a virtual module, we were emitting two files:middleware.mjsthat simply do an export ofonRequestfrom the middleware chunk.middleware.mjsisn't needed anymore, and we directly import the chunk that rollup generates after the build.Testing
This is an internal refactor; existing CI should pass, and no changeset is needed.
Docs
N/A