Turbolinks: clean up injected scripts and styles on page navigation#3283
Merged
Conversation
🦋 Changeset detectedLatest commit: d56eb4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: integration
tony-sull
changed the title
bholmesdev
approved these changes
May 3, 2022
bholmesdev
left a comment
bholmesdev
left a comment
Contributor
There was a problem hiding this comment.
Ahhh so smart! I'm rendered speechless 👏
Contributor
|
Hm, give this a rebase for that failing test. Not sure how these are related... |
tony-sull
changed the title
Merged
nonphoto
pushed a commit
to nonphoto/astro
that referenced
this pull request
May 6, 2022
…ithastro#3283) * client hydration scripts should be removed before navigation * chore: adding a changeset * also cleanup injected styles on page navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #3128
This updates the turbolinks integration to remove any client hydration scripts before page navigation.
By default turbolinks will leave
<head>scripts in place during page navigation, by manually removing them we leave it up to turbolinks to add them back if needed, triggering a fresh script execution in the browser and re-hydrating the components again 🥳styles
Injected style bundles are also cleaned up on navigation now - after each page navigation they're moved down into the body where Turbolinks will clean them up when diffing the new page
Testing
Tested locally with the reproduction from #3128
Docs
None, bugfix only
Note
Why two different methods for cleaning up scripts vs styles? Because it actually works...🤣 If scripts are moved into the body after page navigation it breaks the hydration process. If styles are removed from the head they're never actually replaced with the new page's link (not sure why, some quirk in Turbolinks diffing 🤷)