Skip to content

Prevent sitemap URLs without pathname#3553

Merged
natemoo-re merged 3 commits into
withastro:mainfrom
caioferrarezi:cf-fix-sitemap
Jun 8, 2022
Merged

Prevent sitemap URLs without pathname#3553
natemoo-re merged 3 commits into
withastro:mainfrom
caioferrarezi:cf-fix-sitemap

Conversation

@caioferrarezi

Copy link
Copy Markdown
Contributor

Changes

Testing

This change was tested locally

Docs

It's a small bug fix, we don't need to change the docs

@changeset-bot

changeset-bot Bot commented Jun 7, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 49d1f6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/sitemap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label Jun 7, 2022
@caioferrarezi caioferrarezi changed the title Prevent sitemap URLs with trimmed paths Prevent sitemap URLs without pathname Jun 7, 2022
@caioferrarezi caioferrarezi marked this pull request as ready for review June 7, 2022 21:50

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@natemoo-re natemoo-re merged commit c601ce5 into withastro:main Jun 8, 2022
@caioferrarezi caioferrarezi deleted the cf-fix-sitemap branch June 8, 2022 15:09
@github-actions github-actions Bot mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: Sitemap generation does not contain base path

2 participants