Skip to content

feat: improved sitemap#3579

Merged
tony-sull merged 8 commits into
withastro:mainfrom
alextim:feat/sitemap
Jun 16, 2022
Merged

feat: improved sitemap#3579
tony-sull merged 8 commits into
withastro:mainfrom
alextim:feat/sitemap

Conversation

@alextim

@alextim alextim commented Jun 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

@astrojs/sitemap

  • Split up large sitemap into multiple sitemaps by custom limit. This functionality is provided by sitemap pkg.
  • Ability to add sitemap specific attributes: priority, hangefreq and lastmod.
  • serialize option: final output customization via JS function.
  • Localization support.
  • All config options are validated by zod.

@example/integrations-playground

fix: site option is added to astro.config

@changeset-bot

changeset-bot Bot commented Jun 12, 2022 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5e2356b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/sitemap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Jun 12, 2022
@alextim alextim changed the title Feat/sitemap feat: improved sitemap Jun 13, 2022
natemoo-re
natemoo-re suggested changes Jun 14, 2022
View reviewed changes

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really great! Just concerned about how the automatic link injection is handled.

Comment thread packages/integrations/sitemap/src/process-pages.ts Outdated
@alextim

alextim commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

Done:

  • 'createLinkInHead' logic and its deps - removed;
  • README - updated;
  • some refactoring for cleaner code;
  • tested locally.

natemoo-re
natemoo-re approved these changes Jun 16, 2022
View reviewed changes

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 This is incredible! Thanks so much for contributing all of these awesome changes back upstream!

tony-sull
tony-sull approved these changes Jun 16, 2022
View reviewed changes

@tony-sull tony-sull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this is excellent! Nice work on the thorough docs, logging, and config validation 👍

Ship it! 🚀

@tony-sull tony-sull merged commit 1031c06 into withastro:main Jun 16, 2022
@github-actions github-actions Bot mentioned this pull request Jun 16, 2022
Merged
@alextim

alextim commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Many thanks for your kind words.
It's not completely finished on my side. Hope to continue.

@gabrielpaivadev

gabrielpaivadev commented Jun 16, 2022

Copy link
Copy Markdown

Thank you so much @alextim

@ArmandPhilippot ArmandPhilippot mentioned this pull request Sep 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

@tony-sull tony-sull tony-sull approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alextim @gabrielpaivadev @natemoo-re @tony-sull
⚡