Handle EXIF orientation flag#4021
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: dd26b26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: integration
Member
|
Nice! I found https://github.com/recurser/exif-orientation-examples if these are at all helpful for tests |
tony-sull
approved these changes
Jul 22, 2022
tony-sull
left a comment
tony-sull
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me!
I'll have a larger image PR out today so I'll merge add a couple tests for this while I'm at it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update the metadata retrieval method used by the image integration to take the EXIF orientation flag into account.
An example of this technique is shown in the Sharp docs (3rd example): https://sharp.pixelplumbing.com/api-input#examples
The
image-sizemodule being used here similarly returnsorientationif found.Testing
Not tested yet — would need an image with the flag to do that.
Docs
No docs needed as this is effectively a bug fix.