Skip to content

remove unnecessary ReactDOM.renderToString operation#5218

Merged
natemoo-re merged 5 commits into
withastro:mainfrom
MoustaphaDev:main
Oct 28, 2022
Merged

remove unnecessary ReactDOM.renderToString operation#5218
natemoo-re merged 5 commits into
withastro:mainfrom
MoustaphaDev:main

Conversation

@MoustaphaDev

@MoustaphaDev MoustaphaDev commented Oct 27, 2022

Copy link
Copy Markdown
Member

Changes

Removes an unnecessary ReactDOM.renderToString call

Testing

N/A, this is a simple refactor

Docs

N/A, this is a simple refactor

@changeset-bot

changeset-bot Bot commented Oct 27, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0608aa2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Oct 27, 2022
@MoustaphaDev MoustaphaDev changed the title remove useless ReactDOM.renderToString operation remove unnecessary ReactDOM.renderToString operation Oct 27, 2022
@natemoo-re natemoo-re merged commit 0b12414 into withastro:main Oct 28, 2022
@astrobot-houston astrobot-houston mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants