Skip to content

Update prefetch.mdx to use more technically correct language (discord username finjo)#14030

Open
finleyjb wants to merge 1 commit into
withastro:mainfrom
finleyjb:patch-1
Open

Update prefetch.mdx to use more technically correct language (discord username finjo)#14030
finleyjb wants to merge 1 commit into
withastro:mainfrom
finleyjb:patch-1

Conversation

@finleyjb

@finleyjb finleyjb commented Jun 9, 2026

Copy link
Copy Markdown

Description

Maybe this splitting hairs, but the existing page says that it works for links to the same site. This is not technically correct, because same-site URLs will work on different subdomains. If this does not work on different subdomains, it's technically same-origin rather than same-site.

Maybe this splitting hairs, but the existing page says that it works for links to the same site. This is not [technically correct](https://web.dev/articles/same-site-same-origin), because `same-site` URLs will work on different subdomains. If this does not work on different subdomains, it's technically `same-origin` rather than `same-site`.
@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 769aaab
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a287dfc00db540008ac74ee
😎 Deploy Preview https://deploy-preview-14030--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/prefetch.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston

Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@ArmandPhilippot

Copy link
Copy Markdown
Member

Hi, thanks for taking the time to submit a PR but I'm not sure what this is supposed to fix...

Astro’s prefetching uses <link rel="prefetch"> if supported by the browser, and falls back to the fetch() API otherwise.

See: https://docs.astro.build/en/guides/prefetch/#browser-support

And according to MDN:

<link rel="prefetch"> is used for same-site navigation resources, or for subresources used by same-site pages.

So, according to your link... your fix (same-origin) would be wrong?

@finleyjb

finleyjb commented Jun 10, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants