Update guidance on named slots in framework components#824
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
reviewed
Jun 23, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Member
|
Just one sentence commented above, otherwise, LGTM. @Jutanium - care to provide a DINM? (Dan is not mad.) |
Contributor
|
Out of Astro time for today for a full review + comments. DINM, but instead of destructuring the props, consider accepting EDIT: To be clear, this DOES WORK in Solid, as these props are static elements. It's just not idiomatic to write it this way! |
Member
|
Update branch, to appease the Hippo checks, and LGTM! Thanks Nate! 💜 |
5 tasks
yanthomasdev
added a commit
that referenced
this pull request
Jun 25, 2022
5 tasks
yanthomasdev
added a commit
that referenced
this pull request
Jun 26, 2022
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description