Fix overworld rupees not being properly excluded#1431
Merged
wooferzfg merged 1 commit intowooferzfg:wwrando-dev-tanjo3from Apr 14, 2026
Merged
Fix overworld rupees not being properly excluded#1431wooferzfg merged 1 commit intowooferzfg:wwrando-dev-tanjo3from
wooferzfg merged 1 commit intowooferzfg:wwrando-dev-tanjo3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Rupee" tag gets stripped from location types, so overworld rupees end up having no types. This causes
isProgressLocationto exit early due to the check for the "Defeat Ganondorf" location. That location hasundefinedtype (there is no type entry in its location data), whereas rupeesanity locations just have an empty type. So, to fix, we change the check for the "Defeat Ganondorf" to useisNilinstead. This is also why dungeon and secret caves rupees worked: their types were non-empty after the "Rupee" tag was removed.Report: https://discord.com/channels/453718509600374794/1493320873451716760