Skip to content

fix(kitsu-core): fix deserialisation of relationships from primary data #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wopian merged 1 commit into from
Jun 23, 2022
Merged

fix(kitsu-core): fix deserialisation of relationships from primary data #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/kitsu-core/src/deserialise/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import { linkRelationships } from '../linkRelationships'
*/
function deserialiseArray (array) {
for (let value of array.data) {
if (array.included) value = linkRelationships(value, array.included)
if (value.relationships) value = linkRelationships(value)
value = linkRelationships(value, [ ...array.data, ...(array.included || []) ])
if (value.attributes) value = deattribute(value)
array.data[array.data.indexOf(value)] = value
}
Expand Down
117 changes: 117 additions & 0 deletions packages/kitsu-core/src/deserialise/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,5 +670,122 @@ describe('kitsu-core', () => {
]
})
})

it('deserialises a relationship from the data key', () => {
expect.assertions(1)

const input = deserialise({
data: [
{
id: '1',
type: 'anime',
attributes: { name: 'A' },
relationships: {
prequel: {
data: {
type: 'anime',
id: '42'
}
}
}
},
{
id: '2',
type: 'anime',
attributes: { name: 'B' },
relationships: {
prequel: {
data: {
type: 'anime',
id: '1'
}
}
}
},
{
id: '3',
type: 'anime',
attributes: { name: 'C' },
relationships: {
prequel: {
data: {
type: 'anime',
id: '4'
}
}
}
}
],
included: [
{
id: '4',
type: 'anime',
attributes: { name: 'D' },
relationships: {
prequel: {
data: {
type: 'anime',
id: '42'
}
}
}
}
]
})

const output = {
data: [
{
id: '1',
type: 'anime',
name: 'A',
prequel: {
data: {
id: '42',
type: 'anime'
}
}
},
{
id: '2',
type: 'anime',
name: 'B',
prequel: {
data: {
id: '1',
type: 'anime',
name: 'A',
prequel: {
data: {
id: '42',
type: 'anime'
}
}
}
}
},
{
id: '3',
type: 'anime',
name: 'C',
prequel: {
data: {
id: '4',
type: 'anime',
name: 'D',
prequel: {
data: {
id: '42',
type: 'anime'
}
}
}
}
}
]
}

expect(input).toEqual(output)
})
})
})
⚡