CMM 1237 create cities and region stats card by adalpari · Pull Request #22592 · wordpress-mobile/WordPress-Android

adalpari · 2026-02-12T12:12:43Z

Description

This PR adds Regions and Cities tabs to the Locations stats card alongside the existing Countries tab. I

Key changes:

New location types: Added segmented button selector (Countries / Regions / Cities) with lazy-fetching — each tab only fetches data when first selected
Map fix: Regions and Cities map data is now aggregated by country code so the GeoChart always renders at country resolution. The list below the map still shows individual
regions/cities
Package rename: Moved countries package to locations to better reflect the broader scope
Detail screen: Updated CountriesDetailActivity to support all three location types with correct titles, data, and map rendering
Tests: Added tests for region/city aggregation, location type switching, detail data, and error handling

Testing instructions

Countries tab:

Open Stats > Traffic tab
Scroll to the Locations card (Countries tab selected by default)

Verify the map renders correctly with country-level fills
Verify the country list displays with flags, names, views, and change indicators

Tap "Show all"

Verify the detail screen shows all countries with the map and summary card

Regions tab:

Tap the "Regions" segment in the Locations card

Verify the map renders at country level (countries filled, no "map does not exist" error)
Verify the list below shows individual region names with their views

Tap "Show all"

Verify the detail screen shows all regions

Cities tab:

Tap the "Cities" segment in the Locations card

Verify the map renders at city level
Verify the list below shows individual city names with their views

Tap "Show all"

Verify the detail screen shows all cities

Period switching:

Switch between time periods (7 days, 30 days, etc.)

Verify each location type reloads correctly

Switch location types after changing period

Verify lazy-fetch triggers correctly for unloaded types

Screen_recording_20260219_114330.mp4

…ats-top-authors-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/datasource/StatsDataSourceImpl.kt # gradle/libs.versions.toml

# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/datasource/StatsDataSourceImpl.kt # gradle/libs.versions.toml

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsViewModel.kt

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsDetailActivity.kt

…te-location-and-region-stats-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/countries/CountriesViewModel.kt

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

codecov · 2026-02-19T13:06:24Z

Codecov Report

❌ Patch coverage is 35.91613% with 703 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.15%. Comparing base (4328d05) to head (7a0c26b).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ess/android/ui/newstats/locations/LocationsCard.kt	0.00%	303 Missing ⚠️
...roid/ui/newstats/datasource/StatsDataSourceImpl.kt	0.00%	111 Missing ⚠️
.../android/ui/newstats/repository/StatsRepository.kt	25.54%	100 Missing and 2 partials ⚠️
...roid/ui/newstats/locations/StatsGeoChartWebView.kt	0.00%	52 Missing ⚠️
...ndroid/ui/newstats/locations/LocationsViewModel.kt	85.58%	25 Missing and 22 partials ⚠️
...d/ui/newstats/locations/LocationsDetailActivity.kt	0.00%	38 Missing ⚠️
.../android/ui/newstats/datasource/StatsDataSource.kt	0.00%	28 Missing ⚠️
.../wordpress/android/ui/newstats/NewStatsActivity.kt	0.00%	17 Missing ⚠️
...ss/android/ui/newstats/authors/AuthorsViewModel.kt	89.47%	3 Missing and 1 partial ⚠️
...roid/ui/newstats/locations/LocationsCardUiState.kt	95.65%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22592      +/-   ##
==========================================
- Coverage   38.18%   38.15%   -0.04%     
==========================================
  Files        2254     2253       -1     
  Lines      113442   114096     +654     
  Branches    15802    15890      +88     
==========================================
+ Hits        43315    43528     +213     
- Misses      66534    66958     +424     
- Partials     3593     3610      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…te-location-and-region-stats-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/NewStatsActivity.kt

…-location-and-region-stats-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/NewStatsActivity.kt # WordPress/src/main/java/org/wordpress/android/ui/newstats/countries/CountriesViewModel.kt # WordPress/src/main/java/org/wordpress/android/ui/newstats/mostviewed/MostViewedViewModel.kt # WordPress/src/test/java/org/wordpress/android/ui/newstats/NewStatsViewModelTest.kt # WordPress/src/test/java/org/wordpress/android/ui/newstats/countries/CountriesViewModelTest.kt

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

adalpari · 2026-02-19T14:38:49Z

@nbradbury I've achieved some of the suggestions from here in: e7a02fb, ed8a978, and daaf68a

Fix 1 - WebView memory leak (StatsGeoChartWebView.kt:106-108): Added onRelease callback to AndroidView that calls webView.destroy() when the composable leaves composition. Fix 2 - Unvalidated lat/long (LocationsViewModel.kt:552-554): Changed the filter from a null check to toDoubleOrNull() != null, which validates that latitude and longitude are actually numeric before injecting them into JavaScript. Fix 3 - Missing exception handling (LocationsViewModel.kt and AuthorsViewModel.kt): Wrapped all repository fetch calls in try/catch(Exception) blocks that emit error UI states, matching the pattern used in MostViewedViewModel. Fix 4 - Redundant WebView reloads (StatsGeoChartWebView.kt:77, 93-104): Added a lastLoadedHtml state to track the previously loaded HTML. The update lambda now only calls webView.loadData() when the content actually changes.

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsCardUiState.kt

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsViewModel.kt

nbradbury

I left a couple of comments, but nothing that should hold this PR up

sonarqubecloud · 2026-02-20T09:07:06Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.7% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari added 30 commits February 5, 2026 14:57

Using the new WPComLanguage

86c8c33

Add authors card

cc793fb

Title fix

63cfdcd

Merge remote-tracking branch 'origin/trunk' into feat/CMM-1222-Add-st…

afb9a8f

…ats-top-authors-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/datasource/StatsDataSourceImpl.kt # gradle/libs.versions.toml

Ading tests

61df0ac

detekt

e3d35b4

Extracting common code

15211f8

More code extraction

28d90b9

Renaming

5fa6f50

Reverting rollback change by mistake

f5bf375

Merge branch 'trunk' into feat/CMM-1222-Add-stats-top-authors-card

d664c39

# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/datasource/StatsDataSourceImpl.kt # gradle/libs.versions.toml

Updating version

593648d

Checking token

210aa23

Division by zero fix

b42f1ef

Merge branch 'trunk' into feat/CMM-1222-Add-stats-top-authors-card

e67887d

Fixing the max authors issue

6b37847

Fix tests

0b20520

detekt

106b326

Using the proper endpoint

7eecae8

Update RS

4e7fe7d

Merge branch 'trunk' into feat/CMM-1222-Add-stats-top-authors-card

8f3e6b3

Stop duplicating cards calls

9ea9295

Only fetching visible cards

6d4d712

Fixing loading initial value

cde2cc7

Fixing tests

6021247

detekt

fad69d3

Preventing loadDataIfNeeded race condition

fc30853

Some Pr suggestions

18ff3f4

Adding tests

7329824

Adding new cards

7124249

Adding missing tests

564cd0e

claude bot reviewed Feb 19, 2026

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsViewModel.kt Show resolved Hide resolved

claude bot reviewed Feb 19, 2026

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsViewModel.kt Show resolved Hide resolved

claude bot reviewed Feb 19, 2026

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsDetailActivity.kt Show resolved Hide resolved

adalpari added 3 commits February 19, 2026 12:11

Merge branch 'fix/stats-cards-and-networking' into feat/CMM-1237-Crea…

33938de

…te-location-and-region-stats-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/countries/CountriesViewModel.kt

Reaming countries

705e728

Claude suggestions

fd965f7

adalpari marked this pull request as ready for review February 19, 2026 11:57

adalpari requested a review from nbradbury February 19, 2026 11:58

adalpari and others added 2 commits February 19, 2026 13:30

Fixing tests

e90d345

Trigger CI rebuild

84cb772

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

adalpari added 5 commits February 19, 2026 14:49

Fixing the double endpoint call to top posts and referrers

296eb23

Merge branch 'fix/stats-cards-and-networking' into feat/CMM-1237-Crea…

75fbe02

…te-location-and-region-stats-card # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/NewStatsActivity.kt

Adding try-catch to refresh

e7a02fb

Removing non-used defaultOrder

ed8a978

Using generic objects

daaf68a

Base automatically changed from fix/stats-cards-and-networking to trunk February 19, 2026 14:34

adalpari and others added 2 commits February 19, 2026 15:35

Trigger CI

57a3aed

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nbradbury reviewed Feb 19, 2026

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsCardUiState.kt Outdated Show resolved Hide resolved

nbradbury reviewed Feb 19, 2026

View reviewed changes

WordPress/src/main/java/org/wordpress/android/ui/newstats/locations/LocationsViewModel.kt Outdated Show resolved Hide resolved

nbradbury approved these changes Feb 19, 2026

View reviewed changes

PR suggestions

7a0c26b

adalpari enabled auto-merge (squash) February 20, 2026 09:05

adalpari merged commit 567e0e9 into trunk Feb 20, 2026
21 of 23 checks passed

adalpari deleted the feat/CMM-1237-Create-location-and-region-stats-card branch February 20, 2026 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMM 1237 create cities and region stats card#22592

CMM 1237 create cities and region stats card#22592
adalpari merged 58 commits intotrunkfrom
feat/CMM-1237-Create-location-and-region-stats-card

adalpari commented Feb 12, 2026 •

edited by nbradbury

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

adalpari commented Feb 19, 2026

Uh oh!

Uh oh!

Uh oh!

nbradbury left a comment

Uh oh!

sonarqubecloud bot commented Feb 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adalpari commented Feb 12, 2026 • edited by nbradbury Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adalpari commented Feb 19, 2026

Uh oh!

Uh oh!

Uh oh!

nbradbury left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 20, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adalpari commented Feb 12, 2026 •

edited by nbradbury

Loading

codecov bot commented Feb 19, 2026 •

edited

Loading