RS Post Settings: Device gallery as featured image source

[nbradbury]

Description

Adds the ability to pick a featured image from the device gallery (in addition to the existing WP Media Library option). When a device image is selected, it is uploaded to the site's media library and then set as the featured image.

Key changes:

• Split featured image picker into two options: "Choose from WP Media" and "Choose from device" via a dropdown menu
• Upload flow: copies the selected URI to a temp file, uploads it via MediaCreateParams, and sets the returned media ID as the featured image

Testing instructions

Featured image from WP Media:

1. Open a post's RS settings (requires experimental feature flag)
2. Tap the edit button on the featured image area
3. Select "Choose from WP Media"

• Verify the WP Media picker opens

4. Select an image

• Verify the featured image updates

Featured image from device:

1. Open a post's RS settings
2. Tap the edit button on the featured image area
3. Select "Choose from device"

• Verify the device media picker opens

4. Select a photo

• Verify a loading state appears while uploading
• Verify the featured image updates after upload completes

Remove featured image:

1. With a featured image set, tap the edit button
2. Select "Remove"

• Verify the featured image is removed

featured.mp4

[dangermattic]

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr22690-4ab66b1
	Build Number	1487
	Application ID	org.wordpress.android.prealpha
	Commit	4ab66b1
	Installation URL	0srch039315uo

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr22690-4ab66b1
	Build Number	1487
	Application ID	com.jetpack.android.prealpha
	Commit	4ab66b1
	Installation URL	339ssc4em7vvg

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

❌ Patch coverage is 0.76336% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.58%. Comparing base (f662c9e) to head (4ab66b1).
⚠️ Report is 4 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ress/android/ui/postsrs/PostRsSettingsViewModel.kt	1.66%	59 Missing ⚠️
...android/ui/postsrs/screens/PostRsSettingsScreen.kt	0.00%	37 Missing ⚠️
...rg/wordpress/android/ui/postsrs/UriToFileMapper.kt	0.00%	32 Missing ⚠️
...dpress/android/ui/postsrs/PostRsSettingsUiState.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22690      +/-   ##
==========================================
- Coverage   37.61%   37.58%   -0.04%     
==========================================
  Files        2272     2273       +1     
  Lines      118379   118477      +98     
  Branches    16370    16382      +12     
==========================================
+ Hits        44531    44532       +1     
- Misses      70196    70293      +97     
  Partials     3652     3652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[adalpari]

Overall, it looks and works well.

What do you think about the following points?

• Temp file cleanup is missing: In copyUriToTempFile() (line ~540), a temp file is created in appContext.cacheDir but
  is never deleted after the upload completes (or fails). Over time, repeated picks will accumulate orphan files.
  Consider deleting the temp file in a finally block inside onFeaturedImagePickedFromDevice:

  } finally {
  tempFile?.delete()
  }

• Hardcoded .jpg extension (PostRsSettingsViewModel.kt:~536): The temp file always gets a .jpg suffix regardless of the actual image type (e.g., PNG, WEBP, HEIC). If the upload API or server infers MIME type from the extension, this could cause issues. Consider reading the MIME type from the ContentResolver and mapping it to the correct extension.

• @ApplicationContext in ViewModel (PostRsSettingsViewModel.kt:50): Injecting Context into a ViewModel is generally discouraged in Android architecture guidelines because it makes testing harder and blurs layer boundaries. Consider extracting the copyUriToTempFile logic into a small injectable helper/use-case class (e.g., MediaFileProvider or UriToFileMapper) that holds the Context. This would also make the file operations independently testable.

[nbradbury]

What do you think about the following points?

@adalpari Those are all good points and I've fixed them.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[adalpari]

Thank you for the fixes! LGTM!