Open
Conversation
Member
|
Thanks for the pull request! Could you minimize it? |
…hin a loop to boost performance. I also added missing override annotations to comply with codestyle conventions
Alvari-Kupari
force-pushed
the
codestyle
branch
from
90488eb to
0721d40
Compare
Author
|
My apologies, I had an automatic code formatter which made the diff file include unnecessary changes. I've repushed the changes without formatting to include only the key changes. |
sim-wangyan
requested changes
Feb 8, 2025
Member
sim-wangyan
left a comment
sim-wangyan
left a comment
There was a problem hiding this comment.
the file QB.java has changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored ParserUtil to use a stringbuilder when concatenating a string within a loop to boost performance. Also added miussing override annotations to align with codestyle conventions