Rework iPad's menu resizing

[wutschel]

Description

This PR reworks the menu resizing on iPad. It also fixes an issue reported in this forum post and via AppStore review. Before this rework it was possible to hide the playlist view completely. This could happen because the movable playlist header could be placed behind the playlist toolbar, either by user or by rotation to landscape mode.

The rework takes care that the playlist header is always kept visible and touchable above the playlist toolbar, including rotation use cases.

Summary for release notes

Bugfix: Always keep playlist header visible on iPad

[kodiai]

Kodiai Review Summary

What Changed

Reworked iPad menu resizing to prevent hiding the playlist view completely and ensure the playlist header remains visible above the toolbar during rotation.

Reviewed: core logic

Strengths

• ✅ The bounds checking in touchesMoved:withEvent: (ViewControllerIPad.m:208) properly prevents the playlist header from being dragged beyond the available space
• ✅ The snap-back logic in touchesEnded:withEvent: (ViewControllerIPad.m:223-226) correctly adjusts when the header would overlap the toolbar
• ✅ Rotation handling (ViewControllerIPad.m:649) properly reapplies the layout constraints during device orientation changes

Observations

Impact

[MAJOR] XBMC Remote/ViewControllerIPad.m (533): Potential use of uninitialized variable
The viewWillAppear: method calls changeLeftMenu:maxVisibleMenuItems at ViewControllerIPad.m:533, but maxVisibleMenuItems may not be initialized if viewWillAppear: is called before viewDidLoad. While instance variables are zero-initialized in Objective-C, passing 0 to changeLeftMenu: could cause the menu to collapse to zero height on first appearance. This is particularly risky since the view controller lifecycle doesn't guarantee viewDidLoad runs before viewWillAppear: in all scenarios.

Preference

[MINOR] XBMC Remote/ViewControllerIPad.m (272, 280): Typo in comments
Optional: The comment text uses "seperator" instead of "separator" at lines 272 and 280. While this doesn't affect functionality, fixing the spelling would improve code readability.

Suggestions

• Optional: Consider adding a guard in viewWillAppear: to only call changeLeftMenu: if maxVisibleMenuItems > 0 to handle edge cases where the method might be called before full initialization
• Future consideration: The double-checking logic in both touchesMoved:withEvent: (line 208) and changeLeftMenu: (lines 273-275) could potentially be consolidated to reduce duplication

Verdict

🟡 Ready to merge with minor items -- Optional cleanup suggestions below (no blockers)

Review Details

• Files reviewed: 2
• Lines changed: +26 -10
• Profile: strict (auto, lines changed: 36)
• Author: newcomer (adapted tone)
• Findings: 0 critical, 1 major, 0 medium, 1 minor (includes 2 from summary observations)
• Review completed: 2026-03-27T19:02:12.162Z
• Keyword parsing: No keywords detected

[wutschel]

Squashed and rebased to master.