[Bug] [Bug] Problems with multiple KIDS

[Newbiect]

Describe the problem

I'm having trouble playing content where the manifest has multiple KIDS. This problem only occurs if the KEY for one of those KIDS is missing, but it turns out that other players can play content even with a missing KEY. In the case of Piers, nothing happens when I try to play, but in Omega, the audio plays, and to see the video, I just have to choose a different resolution. So I assume that each KID handles SD, HD, FHD, and UHD.

For example, the manifest in my example contains these KIDS:
01035bd06120028ad47ca81f1514ad4d
0100a7acedd129e7d00010633bd64c44
01017a51d2e8c70f265dd5d580373bd8
01027daa31fdcfc8249607c10856043a
0105d00d01a6f4d4c6ffeb980587041b

I only have KEYS for these.
01035bd06120028ad47ca81f1514ad4d:d868118108cdcde4da7b7a72ed18a12e
0100a7acedd129e7d00010633bd64c44:e795f3ff5d34faf8e44b543937e6a47a

Only with these keys in Omega, activating Manual OSD mode or Fixed resolution, will it play automatically without any problems. The Ask quality mode also works, but this is only possible in Omega; it's not possible in Piers.

Possible fix

I think a possible solution would be to make InputStream not choose a single KID, or to check each one until it can be played.

Steps to reproduce

No response

Debug log

kodi1.log

Stream manifest file(s)

bac310.mpd.txt

Additional info

No response

Operating system(s)

Windows

Operating system version(s)

11

InputStream Adaptive version(s)

22.3.3-Piers

Kodi version(s)

22.0-ALPHA2

[CastagnaIT]

The log has been edited and crucial info needed to understand what is happening are missing
anyway "works" on Omega but not in the correct way
there is a slightly different approach with Piers to manage things that cannot be compared in full

for these use cases yes usually KIDs should be grouped to handle separately SD, HD, FHD, UHD or something similar

Since you don't have all the KIDs solutions that i can think are:

1. Limit the resolutions, so let know ISA the max resolution that can be played with provided KIDs by using resolution_limit parameter on inputstream.adaptive.config property, see https://github.com/xbmc/inputstream.adaptive/wiki/Integration#inputstreamadaptiveconfig- more likely the best solution that you should test

2. I could consider adding a preventive check to automatically exclude streams that use KIDs that are not provided, but this check would not always be consistent, because if i remember correctly, certain manifests may not provide the KIDs in the manifest but can only be obtained from the initialization segment that is downloaded only when playback starts, other manifests such as HLS have similar problem, so this preventive check will only work in very specific cases and would not be very appropriate

as first test solution 1

PS. However, i don't see this as a bug, you just don't provide the required info for playback

[Newbiect]

kodi.log

I hadn't edited the log, I just cleared it before playing. Here it is without clearing anything, just opening Kodi and then trying to play.

I'll try with resolution_limit. Could you please tell me how I can add a preventative control?

[CastagnaIT]

Could you please tell me how I can add a preventative control?

you mean the point 2? if so,
without the necessary knowledge, you cannot
its needed to study the source code and relative manifests use cases behaviors
however yours is a special case so i would avoid making this kind of code change

for the point 1 you need to add the property on your strm file example:
inputstream.adaptive.config={"resolution_limit": "1280x720"}
ofc you need to have all KIDs for all resolutions you include in the resolution range

[CastagnaIT]

closed due to inactivity

[Newbiect]

I fixed it by modifying Session.cpp and adding this:

const auto hasLicenseKey =
    session->drm->HasLicenseKey(session->decrypter,
                                DRM::ConvertKidStrToBytes(initDrmInfo.defaultKid));
if (hasLicenseKey && !*hasLicenseKey)
{
  LOG::Log(LOGWARNING,
           "Disabled stream repr ID %s, AdpSet ID %s, no matching DRM key available for its KID",
           repr->GetId().c_str(), adp->GetId().c_str());
  repr->isPlayable = false;
  continue;
}

The modification adds an extra filter: discard DRM representations that do not have a valid license key for their KID.

And in ClearKeyCencSingleSampleDecrypter.cpp, I did this:

if (!STRING::KeyExists(m_kidPairs, defaultKeyId))
{
  if (m_kidPairs.empty())
  {
    LOG::LogF(LOGERROR, "License data does not have the required KID");
    m_kidPairs.clear();
    return;
  }

  LOG::LogF(LOGWARNING,
            "License data does not have the required default KID, using the first available key as initialization fallback");
  m_kidPairs.insert_or_assign(defaultKeyId, m_kidPairs.begin()->second);
}

Previously: defaultKeyId was missing → aborted;
Now: defaultKeyId is missing, but other keys are present → uses the first key as an initialization fallback and continues.