[AdaptiveTree] IsLastSegment return false if period is the last one#1616
Merged
CastagnaIT merged 1 commit intoxbmc:Piersfrom Aug 3, 2024
Merged
[AdaptiveTree] IsLastSegment return false if period is the last one#1616CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT merged 1 commit intoxbmc:Piersfrom
Conversation
11 tasks
glennguy
approved these changes
Aug 2, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #1586 change set the duration to all periods
this has lead to a different behaviour of
AdaptiveTree::IsLastSegmentseem there is no a specific rule that dash use to signal a end of live playback
therefore we continue to insert segments until the downloads fail
Motivation and context
fix #1614 at least for dash case (hls should be not related)
How has this been tested?
Dash live inserts, single period:
http://daserstedash.akamaized.net/dash/live/2103597/daserste/dvbt2/manifest.mpd (germany geolock)
Dash live inserts, multiple periods: (at period change segments (numbers) downloaded must be exact)
https://livesim2.dashif.org/livesim2/ato_10/testpic_2s/Manifest.mpd
Screenshots (if appropriate):
Types of change
Checklist: