Skip to content

[AdaptiveTree] IsLastSegment return false if period is the last one#1616

Merged
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:islastseg
Aug 3, 2024
Merged

[AdaptiveTree] IsLastSegment return false if period is the last one#1616
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:islastseg

Conversation

@CastagnaIT
Copy link
Copy Markdown
Collaborator

@CastagnaIT CastagnaIT commented Aug 1, 2024

Description

PR #1586 change set the duration to all periods
this has lead to a different behaviour of AdaptiveTree::IsLastSegment

seem there is no a specific rule that dash use to signal a end of live playback
therefore we continue to insert segments until the downloads fail

Motivation and context

fix #1614 at least for dash case (hls should be not related)

How has this been tested?

Dash live inserts, single period:
http://daserstedash.akamaized.net/dash/live/2103597/daserste/dvbt2/manifest.mpd (germany geolock)
Dash live inserts, multiple periods: (at period change segments (numbers) downloaded must be exact)
https://livesim2.dashif.org/livesim2/ato_10/testpic_2s/Manifest.mpd

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT merged commit c7c9c7c into xbmc:Piers Aug 3, 2024
@CastagnaIT CastagnaIT deleted the islastseg branch August 3, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport: Done Type: Fix non-breaking change which fixes an issue v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[K21] Playing DASH (.mpd) Stream stops after some seconds

2 participants