Fix regressions and improvements to stream selection

[CastagnaIT]

Description

• Fix regression double video quality change with «Ask quality», an attempt to fix has been done on PR [Chooser][ask quality] Fix bad preselection and fixed quality #1810 but was not working good, that in some cases cause crashes
• Fix regression on Adaptive quality that dont change while in playback, due to wrong condition on Higher method
• Fix regression on DASH AdaptationSet «default» override parameter for video stream, that was not taken in account
• Add new setting «Limit resolution» to Stream selection «Ask Quality». I thought it might be useful for everyone, when you play multi-codec video a very long list of resolutions can be listed, which you struggle to scroll through, this option limits the list to only the set resolution, at least it tries to limit them based also on the capabilities (streams provided) of the manifest

Motivation and context

new drm rework has changed some code introducing a codec selection with priority order that was incomplete
and other things was need to be fixed

fix #1821

How has this been tested?

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• I have read the Contributing document
• My code follows the Code Guidelines of this project
• My change requires a change to the Wiki documentation
• I have updated the documentation accordingly

[Ronny-nerd]

Thanks CastagnaIT...it works fine...I noticed on Windows 10 Pro ( 64 BIT ) Kodi 22 Piers.

Android 11...Nvidia Shield TV Pro 2019 = OK

[CastagnaIT]

@Ronny-nerd have you tested also the use case of youtube issue #1821?
because im not able to test youtube addon, every time ask me to login (using Kodi Cast extension on browser) but signin menu on addon dont works

[MoojMidge]

This can be simplified to return currAdp immediately if it is default, without needing to continue the loops:

  CAdaptationSet* defaultAdp{nullptr}; // Default determined by codec order

  for (auto& codecCC : videoCodecOrder)
  {
    CAdaptationSet* currAdp{nullptr};
    uint32_t adpIndex{0};
    while ((currAdp = m_adaptiveTree->GetAdaptationSet(adpIndex++)))
    {
      if (currAdp->GetRepresentations().empty() || currAdp->GetStreamType() != StreamType::VIDEO)
        continue;

      if (currAdp->IsDefault())
      {
        return currAdp;
      }
      else if (CODEC::Contains(currAdp->GetCodecs(), codecCC) && !defaultAdp)
      {
        defaultAdp = currAdp;
      }
    }
  }

  return defaultAdp;

[CastagnaIT]

yeah also one less variable, change done
good to go?

[MoojMidge]

Sorry, while the other changes seem to make sense don't have a machine/connectivity to properly runtime test. Only really checked the adaptation set default selection on initial playback start.

There have been some reports of both DRM and non-DRM streams failing to play with v22.2.0 but no logs so I don't know what may be causing it.

[CastagnaIT]

you don't need to test each change, just just to know for your youtube case was ok