[Cleanup] Make GUI error messages less technical#1859
Merged
CastagnaIT merged 1 commit intoxbmc:Piersfrom May 12, 2025
Merged
Conversation
Collaborator
Author
|
CC @ksooo |
ksooo
reviewed
May 9, 2025
| return SResult::Error("Unable to determine type of manifest file."); | ||
| { | ||
| LOG::LogF(LOGERROR, "Unable to determine type of manifest file."); | ||
| return SResult::Error("A problem occurred in the stream initialization. See the log for details."); |
Member
There was a problem hiding this comment.
-
If you want to make the messages less technical, then pointing users to the log is not a good approach. Most of the users have no idea how to read the log, and many of them do not even know where to find the log. For Kodi 22 we removed the "see log for details" part of many error message strings., for exactly this reason
-
If this is for end users, these string should be localizable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make GUI error messages less technical
Motivation and context
as suggested from comment: #1828 (comment)
How has this been tested?
Screenshots (if appropriate):
Types of change
Checklist: