Skip to content

[Cleanup] Make GUI error messages less technical#1859

Merged
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:err_msg
May 12, 2025
Merged

[Cleanup] Make GUI error messages less technical#1859
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:err_msg

Conversation

@CastagnaIT
Copy link
Copy Markdown
Collaborator

Description

Make GUI error messages less technical

Motivation and context

as suggested from comment: #1828 (comment)

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers labels May 9, 2025
@CastagnaIT
Copy link
Copy Markdown
Collaborator Author

CC @ksooo

Comment thread src/Session.cpp Outdated
return SResult::Error("Unable to determine type of manifest file.");
{
LOG::LogF(LOGERROR, "Unable to determine type of manifest file.");
return SResult::Error("A problem occurred in the stream initialization. See the log for details.");
Copy link
Copy Markdown
Member

@ksooo ksooo May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If you want to make the messages less technical, then pointing users to the log is not a good approach. Most of the users have no idea how to read the log, and many of them do not even know where to find the log. For Kodi 22 we removed the "see log for details" part of many error message strings., for exactly this reason

  2. If this is for end users, these string should be localizable.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@CastagnaIT CastagnaIT merged commit 5c003c1 into xbmc:Piers May 12, 2025
10 checks passed
@CastagnaIT CastagnaIT deleted the err_msg branch May 12, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants