Skip to content

[FragmentedSampleReader] Reset crypto info on change#1916

Merged
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:fix_crypto
Sep 29, 2025
Merged

[FragmentedSampleReader] Reset crypto info on change#1916
CastagnaIT merged 1 commit intoxbmc:Piersfrom
CastagnaIT:fix_crypto

Conversation

@CastagnaIT
Copy link
Copy Markdown
Collaborator

Description

If crypto info has been set previously, and the current package does not have protection, it must be reset to prevent the decryptor from attempting to decrypt unencrypted content

Motivation and context

the PR #1790 highlighted another critical issue resulting from the attempt to fix the previous problem

the m_protectedDesc is cleared when there is no protection,
but you forgot to reset m_readerCryptoInfo, as member it is not cleared automatically

fix #1865

How has this been tested?

user reported n€tflix works

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

If crypto info has been set previously, and the current package does not use it, it must be reset to prevent the decryptor from attempting to decrypt unencrypted content
@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue Backport: Needed v22 Piers labels Sep 26, 2025
@CastagnaIT CastagnaIT merged commit 891ec21 into xbmc:Piers Sep 29, 2025
11 checks passed
@CastagnaIT CastagnaIT deleted the fix_crypto branch September 29, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport: Done Type: Fix non-breaking change which fixes an issue v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Netflix H264 not starting properly starting with ISA Omega V 21.5.10

1 participant