Removed last PTS video seek workaround on subtitles#1990
Closed
CastagnaIT wants to merge 1 commit intoxbmc:Piersfrom
Closed
Removed last PTS video seek workaround on subtitles#1990CastagnaIT wants to merge 1 commit intoxbmc:Piersfrom
CastagnaIT wants to merge 1 commit intoxbmc:Piersfrom
Conversation
It was used because Kodi core did not stream seek on subtitles when subtitles were enabled/disabled or when changing tracks (which is essentially similar)
CastagnaIT
added
Type: Cleanup
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thexai
reviewed
Jan 31, 2026
| constexpr uint64_t NO_VALUE = std::numeric_limits<uint64_t>::max(); | ||
|
|
||
| // Kodi VideoPlayer internal buffer | ||
| constexpr uint64_t KODI_VP_BUFFER_SECS = 8; |
Member
There was a problem hiding this comment.
Also this was wrong currently because video player buffer (queue) is not 8 seconds anymore from xbmc/xbmc#25360
Now is configurable and the default is 4s.
Collaborator
Author
There was a problem hiding this comment.
i'm not interested in changing it because the root of problem is in the VP side
anyway better a higher value than a low one since there is no way to obtain the current used value
Collaborator
Author
|
closed because PR xbmc/xbmc#27770 dont fix anymore demuxers callbacks |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was used because Kodi core did not stream seek on subtitles when subtitles were enabled/disabled or when changing tracks (which is essentially similar)
Motivation and context
has been proposed a fix on kodi core that can cover also this lack
PR: xbmc/xbmc#27770
so this PR depends from it
How has this been tested?
stream with multiple subtitles:
-> enable / disable subtitles from different point of playback
-> change subtitles during playback
in both cases, subtiltes must result in-sync with video playback
tested also on multi-chapters (multi-periods) stream
Screenshots (if appropriate):
Types of change
Checklist: