Merged
Conversation
CVariant in the main XBMC tree.
phunkyfish
requested changes
Mar 29, 2025
Collaborator
phunkyfish
left a comment
phunkyfish
left a comment
There was a problem hiding this comment.
Just one minor. Otherwise looks good.
Would you like this to be released? If so you would need to add a commit that updates the addon.xml.in (increment the micro version as its fix) and add a changelog entry.
Contributor
Author
|
Yes, I think this is an important fix that needs to go to release. I did the requested edits. |
Collaborator
|
Released. Should appear on binary addon servers over the next while. Thanks for the contribution! |
7 tasks
Contributor
|
@phunkyfish This also hits Omega. Debian's approaching full freeze now so I upgraded and was immediately struck. I will make a targeted bugfix release into Debian but I'd maake one more upstream release of 21.3.8 just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put CVariant into ffmpegdirect namespace to avoid collisions with CVariant in XBMC tree.
This fixes Kodi crashes as described in #319