Donor wall is broken

[yol]

This doesn't look right: https://kodi.tv/donate/wall/

[pkscout]

The ones that say "mention my name" and "don't mention my name" must be coming from somewhere else besides the new site (that language was used in the old form on the old site). I also wonder if the "null" ones are too. I can add some logic to change "null" to Anonymous, but that return value never came up in testing. I guess I can also map the other two pieces of text to Anonymous, but we should figure out what is generating that data. I don't have access to the AWS database anymore, so I can't see, delete, or fix the data in its raw form.

[yol]

I don't have access to the AWS database anymore

You have now :)

PayPal: The entries might be from stray PayPal IPNs that arrived late after changing the settings, or from recurring donations that were initially set up like this and now repeat those values every payment. I think we can fix up those that are there now manually, but if more of those crop up and it becomes a steady problem, I'll find a way to fix the values before they enter the DB.

Stripe: All transactions from Stripe came up empty as far as names are concerned. I checked the raw webhooks and client_reference_id is set to values such as "undefined" or "nullnull" (as string). Could this be a problem with the form on the website?

[pkscout]

I'll check this weekend. Of course this all worked it staging, so not sure yet if it's just a weird transition issue or something else.

[yol]

I've just taken a very quick look, my feeling is that there might be a confusion with otForum vs. forum variables in the JS

[pkscout]

@yol was right. I had changed some variable names at some point and missed a couple references to otForum and then apparently didn't test things again. Bad me. The form is fixed now and was tested locally and in staging. I also got into the AWS DynamoDB and deleted any of the bad references (the null names as well as the "mention my name" ones) and rebuilt the site. Those donations now show an Anonymous. I think that resolves all the issues, but I'll leave this open while we keep an eye on it and confirm in production.

[yol]

The PayPal issues are still there and I think that "old" donation subscriptions (i.e., that were made on the old site) will just keep their option_values indefinitely. So I've updated the aws scripts to fix them up automatically, see https://github.com/xbmc/aws/commit/e70a9513282a0d23543f6e351b418ebf18ef8198

@Darren-Hill has mentioned that he still receives IPN failure notifications, so I'm going to look into that too once I can log into PayPal. It seems like many are getting successfully delivered to the new address, though.

For the Stripe side of things, I think the fix got rid of the undefined stuff, but we still get nullnull quite often. I think #199 should fix that.

I also went through the DynamoDB again and removed all the null entries and fixed the wrong PayPal entries manually.

[pkscout]

I think the issues mentioned here are all resolved, so I'm closing this.