Skip to content

[plugin.audio.zophar] 1.0.0#4689

Merged
romanvm merged 1 commit intoxbmc:nexusfrom
dudanov:nexus-zophar-addon
Jul 27, 2025
Merged

[plugin.audio.zophar] 1.0.0#4689
romanvm merged 1 commit intoxbmc:nexusfrom
dudanov:nexus-zophar-addon

Conversation

@dudanov
Copy link
Copy Markdown

@dudanov dudanov commented Jul 16, 2025

Description

This addon for listening classic games soundtracks from Zophar's Domain site.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@dudanov dudanov force-pushed the nexus-zophar-addon branch from 6df8f99 to e869c32 Compare July 16, 2025 07:00
def search(context: str, console: str) -> GameListPage:
html = get_page(SEARCH_PATH, search=context, search_consoleid=console)
page = parse_page(html)
assert isinstance(page, GameListPage)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a show stopper but a small hint. Kodi Python runs with '-o' flag, so asserts don't work.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, Roman. I'll keep it in mind for the future. This assert is more for typing and my linter, so that it knows the exact type of the object.

@romanvm romanvm merged commit b9f4df5 into xbmc:nexus Jul 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants