[plugin.video.mlbtv@matrix] 2026.2.27+matrix.1

[eracknaphobia]

Add-on details:

• General

  • Add-on name: MLB.TV®
  • Add-on ID: plugin.video.mlbtv
  • Version number: 2026.2.27+matrix.1
  • Kodi/repository version: matrix

• Code location

  • URL: https://github.com/eracknaphobia/plugin.video.mlbtv

Watch every out-of-market regular season game in the office or on the go. The #1 LIVE
Streaming Sports Service

Description of changes:

        - bypass skip adjust settings when skipping commercials
        - stream finder extra innings LI correction
        - skip bugfix at end-of-game
        - auto upload Stream Finder form
        - proxy playback fix (used for stream length padding)

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

[kodiai]

Kodiai Review Summary

What Changed

Bug fixes for MLB.TV addon including commercial skip logic improvements, extra innings handling, and proxy playback fixes.

Reviewed: core logic

Strengths

• ✅ Added defensive check at line 1033 to prevent IndexError after popping from skip_markers list
• ✅ Improved UTF-8 decoding with error handling (line 116) to prevent crashes on malformed content

Observations

Impact

[MAJOR] plugin.video.mlbtv/resources/lib/mlbmonitor.py (1021, 1025): IndexError when skip_markers is empty
Lines 1021-1028 access skip_markers[0] without checking if the list is non-empty. While line 1004 checks len(skip_markers) == 0 and breaks, the list can become empty during iteration at line 1032 within the while loop, then lines 1021-1028 will access skip_markers[0] on the next iteration before the outer loop condition at line 1004 is re-evaluated.

[MEDIUM] plugin.video.mlbtv/service.py (139): Potential IndexError when URI delimiters are malformed
Line 139 accesses url_split[0] without verifying the split produced at least one element. If URI_END_DELIMETER is at position 0 of line_split[1], split() could produce an empty result.

Preference

[MINOR] plugin.video.mlbtv/service.py (76): Missing closing tags in HTML
Optional: The HTML form is missing closing </p> tag before </form>. While browsers may tolerate this, proper nesting would be </p></form>.

Suggestions

• Optional: Consider extracting the skip_markers[0] access pattern into a helper that safely checks bounds
• Future consideration: Add comprehensive bounds checking across all list access patterns in the skip marker logic

Verdict

🔴 Address before merging -- 1 blocking issue(s) found (CRITICAL/MAJOR)

Review Details

• Files reviewed: 3
• Lines changed: +19 -14
• Profile: strict (auto, lines changed: 33)
• Author: core (adapted tone)
• Findings: 0 critical, 1 major, 1 medium, 1 minor (includes 3 from summary observations)
• Review completed: 2026-03-02T16:29:52.173Z
• Keyword parsing:
  • focus hints: [PLUGIN.VIDEO.MLBTV@MATRIX], [PLUGIN.VIDEO.MLBTV]