[plugin.audio.ampache@matrix] 3.2.1+matrix.1

[lusum]

Description

• TLS/SSL updates
• Code improvements and refactoring
• Bug fix
• API update
• Add swedish translation ( thanks to @yeager )

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practice but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.
• If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

[kodiai]

Kodiai Review Summary

What Changed

Version bump to 3.2.1+matrix.1 with TLS/SSL updates, code refactoring, bug fixes, API update to 680001, and Swedish translation addition.

Reviewed: core logic

Strengths

• ✅ TLS protocol upgraded from TLSv1 to TLSv1_2 for Python 2 (ampache_connect.py:605), improving security
• ✅ Directory existence check added before iteration in art.py:915 and art_clean.py:953, preventing crashes

Observations

Impact

[CRITICAL] plugin.audio.ampache/resources/lib/art_clean.py (962): Invalid syntax for Python 2/3 compatibility
Causes syntax error at runtime when PermissionError is raised on Python 3, breaking exception handling: except PermissionError if not PY2 else OSError: is invalid Python syntax

[MAJOR] plugin.audio.ampache/resources/lib/ampache_connect.py (553): Bare except silently catches all exceptions
Catches all exceptions including KeyboardInterrupt and SystemExit when accessing server configuration, masking critical errors and making debugging difficult

[MAJOR] plugin.audio.ampache/resources/lib/ampache_plugin.py (831): Raises exception inside try block instead of returning
raise ValueError("Error getting playing file") in line 832 within a try-except that catches all exceptions defeats the error handling logic, making the outer exception handling unreachable

Verdict

🔴 Address before merging -- 3 blocking issue(s) found

Review Details

• Files reviewed: 9
• Lines changed: +634 -93
• Profile: minimal (auto, lines changed: 727)
• Author: core (adapted tone)
• Findings: 1 critical, 2 major, 0 medium, 0 minor (includes 3 from summary observations)
• Review completed: 2026-03-09T18:40:46.955Z
• Keyword parsing:
  • focus hints: [PLUGIN.AUDIO.AMPACHE@MATRIX]

[lusum]

Il will correct the problems and i will submit a new version