[plugin.audio.ampache@matrix] 3.2.4+matrix.1

[lusum]

Description

• TLS/SSL updates
• Code improvements and refactoring
• Bug fix
• API update
• Add swedish translation ( thanks to @Yaeger )

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practice but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.
• If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

[kodiai]

Kodiai Review Summary

What Changed

Version bump to 3.2.4+matrix.1 with TLS/SSL updates, code improvements, bug fixes, API updates (600001→680001), and Swedish translation.

Reviewed: core logic

Strengths

• ✅ TLS protocol upgraded from TLSv1 to TLSv1_2 for Python 2 environments (ampache_connect.py:632)
• ✅ Added proper None checks before accessing _connectionData throughout ampache_connect.py (lines 552-554, 592-594, 601-603, etc.)

Observations

Impact

[CRITICAL] plugin.audio.ampache/resources/lib/ampache_connect.py (148-151): SSL certificate verification completely disabled creates man-in-the-middle vulnerability
When disable_ssl_certs setting is enabled, the code sets check_hostname = False and verify_mode = ssl.CERT_NONE, allowing attackers to intercept and modify traffic to/from the Ampache server. This exposes authentication credentials and music streaming data to interception.

Verdict

🔴 Address before merging -- 1 blocking issue(s) found

Review Details

• Files reviewed: 9
• Lines changed: +712 -123
• Profile: minimal (auto, lines changed: 835)
• Author: core (adapted tone)
• Findings: 1 critical, 0 major, 0 medium, 0 minor (includes 1 from summary observations)
• Review completed: 2026-03-26T20:24:26.635Z
• Keyword parsing:
  • focus hints: [PLUGIN.AUDIO.AMPACHE@MATRIX]

[lusum]

Kodiai signal a wrong error, disabling ssl certificates was a requested feature and used only when the user wants to disable it for testing purposes

[kodiai]

kodiai response

Decision: APPROVE
Issues: none

[lusum]

the commits are a mess, i close this request