Clean up legacy Agent 5 code#15
Merged
xenon8 merged 6 commits intoxenon8/puppet-8-upgradefrom Mar 6, 2025
Merged
Conversation
xenon8
reviewed
Mar 6, 2025
xenon8
requested changes
Mar 6, 2025
Owner
xenon8
left a comment
xenon8
left a comment
There was a problem hiding this comment.
@fanny-jiang just one comment on the http_check class
fanny-jiang
changed the title
xenon8
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CircleCI: https://app.circleci.com/pipelines/github/DataDog/puppet-datadog-agent/1139/workflows/1221affb-fd6b-4c13-955c-4cbe9c692c45
agent_version: 5is configuredMotivation
Drop support for Agent 5
Additional Notes
Expected module behavior:
agent_version: 5oragent_major_version: '5.x.xare configured, the module apply should fail with the message:agent_major_version must be either 6 or 7, not 5agent_versionnoragent_major_versionparams are configured, the module should install/upgrade the agent to the default latest agent 7.Describe your test plan