logging: update to latest EGC, adjust logging macros#85
Open
mardy wants to merge 2 commits intoxerpi:mainfrom
Open
logging: update to latest EGC, adjust logging macros#85mardy wants to merge 2 commits intoxerpi:mainfrom
mardy wants to merge 2 commits intoxerpi:mainfrom
Conversation
We should not use the logging macros from EGC (since they could change according to EGC's needs), but rather use our owns.
Fails with ``` [32/33] Linking C executable fakemote.elf FAILED: fakemote.elf : && /opt/devkitpro/devkitARM/bin/arm-none-eabi-gcc -g -Og -DDEBUG -mcpu=arm926ej-s -mthumb -mthumb-interwork -mbig-endian -nostartfiles -nostdlib -Wl,-T,/__w/fakemote/fakemote/link.ld,-Map,fakemote.map -Wl,--gc-sections -Wl,-static CMakeFiles/fakemote.dir/source/start.o CMakeFiles/fakemote.dir/source/main.o CMakeFiles/fakemote.dir/source/hci_state.o CMakeFiles/fakemote.dir/source/injmessage.o CMakeFiles/fakemote.dir/source/input_device.o CMakeFiles/fakemote.dir/source/button_map.o CMakeFiles/fakemote.dir/source/fake_wiimote.o CMakeFiles/fakemote.dir/source/fake_wiimote_mgr.o CMakeFiles/fakemote.dir/source/libc.o CMakeFiles/fakemote.dir/source/wiimote_crypto.o CMakeFiles/fakemote.dir/source/conf.o -o fakemote.elf embedded-game-controller/cios-lib/libcios-lib.a -lgcc embedded-game-controller/embedded-game-controller/libembedded-game-controller.a embedded-game-controller/cios-lib/libcios-lib.a -lgcc && : /opt/devkitpro/devkitARM/lib/gcc/arm-none-eabi/15.2.0/../../../../arm-none-eabi/bin/ld: fakemote.elf section `.rodata' will not fit in region `exe' /opt/devkitpro/devkitARM/lib/gcc/arm-none-eabi/15.2.0/../../../../arm-none-eabi/bin/ld: section .data LMA [13979000,1397908f] overlaps section .rodata LMA [13977410,1397938b] /opt/devkitpro/devkitARM/lib/gcc/arm-none-eabi/15.2.0/../../../../arm-none-eabi/bin/ld: region `exe' overflowed by 908 bytes collect2: error: ld returned 1 exit status ```
Collaborator
Author
|
Please pay attention to the second commit: I had to disable the Debug build to to size issues. But maybe there's a way to increase the size and bring the debug build back? The reason for the failure is that -O2 was removed from EGC's debug builds, since it effectively makes debugging with gdb much harder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after embedded-game-controller/embedded-game-controller#17
We should not use the logging macros from EGC (since they could change according to EGC's needs), but rather use our owns.