Skip to content

update module versions again#7465

Merged
waruqi merged 1 commit intodevfrom
modules
Apr 9, 2026
Merged

update module versions again#7465
waruqi merged 1 commit intodevfrom
modules

Conversation

@waruqi
Copy link
Copy Markdown
Member

@waruqi waruqi commented Apr 8, 2026

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several test files by replacing local compiler version constants with function calls. While most files were updated correctly, a critical issue was identified in tests/projects/c++/modules/reuse_strict_private_defines/test.lua where the new functions are called but have not been defined, which will result in a runtime error.

Comment on lines 4 to 6
local PRIVATE_DEFINE = "PRIVATE_DEP_DEFINE_DO_NOT_PROPAGATE"
local PUBLIC_SYSINCLUDEDIR = path.translate("src/include")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The functions clang_min_ver, gcc_min_ver, and msvc_min_ver are used in main but are not defined in this file. They appear to be missing from the scope, which will cause a runtime error.

@waruqi waruqi added this to the v3.0.9 milestone Apr 9, 2026
@waruqi waruqi merged commit cfb2409 into dev Apr 9, 2026
80 of 86 checks passed
@waruqi waruqi deleted the modules branch April 9, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant