Merged
Conversation
Owner
|
Cool. Though, I'm a bit lost with the PRs 😅 (sorry back from holidays + sick days), which one should I merge first, this one is ok? |
Contributor
Author
|
If you merge #13 first I can commit to this PR to use |
Rohansi
force-pushed
the
optional-watch
branch
from
a24d6af to
7629b88
Compare
Contributor
Author
|
This should be good to go now. Let me know if you see anything wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12.
This isn't complete yet. Waiting for #13 to be resolved because the remaining changes need to update the (currently broken) watch logic in
MountFileSystem.