Fix dispose not removing the watchers from aggregate and mount FS#34
Merged
xoofx merged 4 commits intoxoofx:masterfrom Feb 6, 2019
Merged
Fix dispose not removing the watchers from aggregate and mount FS#34xoofx merged 4 commits intoxoofx:masterfrom
xoofx merged 4 commits intoxoofx:masterfrom
Conversation
Owner
|
Thanks! The new package is released. Didn't realize that the last one was almost a year old! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These instances get added to a list when calling
Watchbut were never being removed when callingDisposeon the watcher instance. The memory FS already does this so it was not affected.I also updated the test project to try and get it working in my VS. I only managed to get it working with ReSharper's test runner, not VS's. It also works with
dotnet test.Also, could we get 0.7.3 on NuGet when you're free?