Conversation
Member
Author
|
@Tyriar, @anthonykim1 This also removes the Image-load shim around missing |
Member
Author
|
@Tyriar, @anthonykim1 Added numbers for vscode above in the table. Something in vscode terminal is sucking hard on the effective throughput, especially when the input is big (thus JPEG is less affected). To repro yourself in vscode terminal: git clone git@github.com:jerch/sixel-bench.git
cd sixel-bench
cat parts_* > blobs.tar.gz
tar -zxf blobs.tar.gz
reset
python run.py data/data.sixel
reset
python run.py data/data.iip.pngThe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds QOI support to the image addon.
Part of #5845.
Some benchmarks with https://github.com/jerch/sixel-bench (all my machine™ with Chromium):
Observation: QOI leads in throughput and FPS. Sixel is close behind but unusable for quick encoding and due its lower quality. The kitty implementation with PNG is worse than for IIP, prolly not as heavily optimized yet.
On a sidenote: Webkit/Safari is actually faster than Chromium yielding 2.82s (46.45 MB/s, 243.31 fps) for QOI. For Kitty it performs much worse with ~12 MB/s.
Edit: Added vscode numbers for comparison to xterm.js demo.