XRENDERING-660: Get rid of the dependency on the xdom+xml syntax#230
Merged
Conversation
* Pass the label via an XDOM instance instead of rendering/parsing to xdom+xml syntax. * Move the reference type detection into the XWikiReferenceTagHandler to simplify XHTMLXWikiGeneratorListener.
tmortagne
approved these changes
Nov 2, 2022
* Reduce number of dependencies to other classes in XWikiCommentHandler * Add since-comments to new methods in XWikiWikiReference
* Update comments, no plan to backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not super happy with the new workaround but I think it's better than the old one, avoids the dependency on another syntax and shouldn't cause any breakages as we're (mostly) still doing the same. The better design would be to introduce begin/end methods for references but then we would need (probably) major changes in WikiModel to properly support everything that currently works like having independent styling in link labels.