Skip to content

Allow labels and annotation field validation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacov merged 1 commit into from
Sep 29, 2025
Merged

Allow labels and annotation field validation #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/cmd/sql-sql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,26 @@ import (

// isValidFieldIdentifier checks if a field name matches the allowed pattern
func isValidFieldIdentifier(field string) bool {
// Check for labels.* pattern
if strings.HasPrefix(field, "labels.") {
labelKey := field[7:] // Remove "labels." prefix
// K8s label keys: alphanumeric, hyphens, underscores, dots
// Must start and end with alphanumeric character
labelPattern := `^[a-zA-Z0-9]([a-zA-Z0-9\-_.]*[a-zA-Z0-9])?$`
match, _ := regexp.MatchString(labelPattern, labelKey)
return match
}

// Check for annotations.* pattern
if strings.HasPrefix(field, "annotations.") {
annotationKey := field[12:] // Remove "annotations." prefix
// K8s annotation keys: similar to labels but more flexible
// Can contain alphanumeric, hyphens, underscores, dots, and slashes
annotationPattern := `^[a-zA-Z0-9]([a-zA-Z0-9\-_./]*[a-zA-Z0-9])?$`
match, _ := regexp.MatchString(annotationPattern, annotationKey)
return match
}

// Matches patterns like:
// - simple: name, first_name, my.field
// - array access: items[0], my.array[123]
Expand Down
⚡