Skip to content

[Feature] Added QR code scanning functionality to add deeplink#39

Merged
yogeshpaliyal merged 6 commits intoyogeshpaliyal:masterfrom
Mutant-Slayer:feature/qr-code-scanner
Aug 8, 2025
Merged

[Feature] Added QR code scanning functionality to add deeplink#39
yogeshpaliyal merged 6 commits intoyogeshpaliyal:masterfrom
Mutant-Slayer:feature/qr-code-scanner

Conversation

@Mutant-Slayer
Copy link
Copy Markdown
Contributor

@Mutant-Slayer Mutant-Slayer commented Aug 8, 2025

QR scanning functionality

  1. This PR will fix this issue Add QR Code scanner to scan for links #35
  2. Used Zxing library for this Zxing
  3. Added scheme check for validating deeplink, while adding them instead of checking them while invoking

Video Recording

Screen_recording_20250808_221419.mp4

@Mutant-Slayer
Copy link
Copy Markdown
Contributor Author

@yogeshpaliyal Please review this.

@yogeshpaliyal
Copy link
Copy Markdown
Owner

run ./gradlew formatKotlin to auto fix lint issues.

@Mutant-Slayer
Copy link
Copy Markdown
Contributor Author

@yogeshpaliyal Cant we run lint check while pushing the code??

@yogeshpaliyal
Copy link
Copy Markdown
Owner

It is already added as prePush hook

@Mutant-Slayer
Copy link
Copy Markdown
Contributor Author

Finally it passed. Thanks a lot.

@Mutant-Slayer
Copy link
Copy Markdown
Contributor Author

Okay on prepush of Master branch??

@yogeshpaliyal
Copy link
Copy Markdown
Owner

not just the master but other branches as well

@yogeshpaliyal yogeshpaliyal merged commit 9969ac9 into yogeshpaliyal:master Aug 8, 2025
1 check passed
@yogeshpaliyal
Copy link
Copy Markdown
Owner

Merged @Mutant-Slayer Thank you for the contribution 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants