[DX] Remove need for container#33
Open
pieterocp wants to merge 4 commits intoyogevbd:masterfrom
Open
Conversation
|
Now that there's an NPM incident this would help. |
Author
|
@giordano think swapping out to use uses: pieterocp/enforce-label-action@remove-need-for-container Should work since it should be self contained. |
Author
|
Been thinking about this one, the use of a container isn't too bad, just that the building + install is a bit unnecessary, so going to move the build into it's own PR, keep the dockerfile bits and bobs, but not have install and tsc be a runtime, but a build time action. |
|
Not using a container would also make it possible to use this with the new But this repo didn't merge any updates in the past 5 years. Perhaps time for someone to fork it? |
Author
|
@yogevbd hey big man, any chance to have a review/look at some PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off the back of the suggestion in #32, this should speed up the runtime a bit as it won't need to install + build every time.
We should probably also add an action to run the build step to check that nobody has been cheeky and snuck in a bit of js which has nothing to do with the typescript.