Skip to content

[DX] Remove need for container#33

Open
pieterocp wants to merge 4 commits intoyogevbd:masterfrom
pieterocp:remove-need-for-container
Open

[DX] Remove need for container#33
pieterocp wants to merge 4 commits intoyogevbd:masterfrom
pieterocp:remove-need-for-container

Conversation

@pieterocp
Copy link
Copy Markdown

Off the back of the suggestion in #32, this should speed up the runtime a bit as it won't need to install + build every time.

We should probably also add an action to run the build step to check that nobody has been cheeky and snuck in a bit of js which has nothing to do with the typescript.

  • runs a bunch of upgrade across the board.

@giordano
Copy link
Copy Markdown

Now that there's an NPM incident this would help.

@pieterocp
Copy link
Copy Markdown
Author

@giordano think swapping out to use

uses: pieterocp/enforce-label-action@remove-need-for-container

Should work since it should be self contained.

@pieterocp
Copy link
Copy Markdown
Author

Been thinking about this one, the use of a container isn't too bad, just that the building + install is a bit unnecessary, so going to move the build into it's own PR, keep the dockerfile bits and bobs, but not have install and tsc be a runtime, but a build time action.

@fingolfin
Copy link
Copy Markdown

Not using a container would also make it possible to use this with the new ubuntu-slim runners.

But this repo didn't merge any updates in the past 5 years. Perhaps time for someone to fork it?

@pieterocp
Copy link
Copy Markdown
Author

@yogevbd hey big man, any chance to have a review/look at some PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants